From 761811d71b734003d53afe07d2a85cd70eeb5708 Mon Sep 17 00:00:00 2001 From: Neale Pickett Date: Wed, 20 Nov 2019 16:23:01 -0800 Subject: [PATCH 1/3] Make top-scoring team take full width --- theme/scoreboard.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/theme/scoreboard.js b/theme/scoreboard.js index 8aa8e98..0c4d836 100644 --- a/theme/scoreboard.js +++ b/theme/scoreboard.js @@ -111,11 +111,15 @@ function scoreboardInit() { } winners.sort(teamCompare) winners.reverse() + + // Let's make some better names for things we've computed + let winningScore = winners[0].overallScore + let numCategories = Object.keys(highestCategoryScore).length // Clear out the element we're about to populate Array.from(element.childNodes).map(e => e.remove()) - let maxWidth = 100 / Object.keys(highestCategoryScore).length + let maxWidth = 100 / winningScore for (let team of winners) { let row = document.createElement("div") let ncat = 0 @@ -125,8 +129,6 @@ function scoreboardInit() { let catPct = catTeam / catHigh let width = maxWidth * catPct - console.log(catHigh, catTeam, catPct) - let bar = document.createElement("span") bar.classList.add("category") bar.classList.add("cat" + ncat) From acbd009136d780671098c89a231a82d7b08ff450 Mon Sep 17 00:00:00 2001 From: John Donaldson Date: Wed, 20 Nov 2019 18:29:44 -0600 Subject: [PATCH 2/3] Made to-scoring teams full-width --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8b37b48..8765bfa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] +### Fixed +- Made top-scoring teams full-width ## [3.4.2] - 2019-11-18 ### Fixed From 07b4bd110107c19d7d25ad7849694818a8de54d1 Mon Sep 17 00:00:00 2001 From: John Donaldson Date: Wed, 20 Nov 2019 18:30:48 -0600 Subject: [PATCH 3/3] Releasing v3.4.3 --- CHANGELOG.md | 2 ++ VERSION | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8765bfa..c99e9f3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] + +## [3.4.3] - 2019-11-20 ### Fixed - Made top-scoring teams full-width diff --git a/VERSION b/VERSION index 4d9d11c..6cb9d3d 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -3.4.2 +3.4.3