Fix FF trying to load a URL on drag drop

This commit is contained in:
Neale Pickett 2021-03-05 14:05:36 -07:00
parent fbc23b2c46
commit 30754fa8e9
2 changed files with 21 additions and 8 deletions

View File

@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [unreleased]
### Changed
- example/5/draggable.js fix for FireFox to prevent dropping a draggable trying to load a URL
## [v4.1.1] ## [v4.1.1]
### Removed ### Removed
- ppc64le and i386 builds of github, because ppc64le keep failing mysteriously, and we don't need them anyhow. - ppc64le and i386 builds of github, because ppc64le keep failing mysteriously, and we don't need them anyhow.

View File

@ -22,16 +22,25 @@ function draggableHandleDragOver(e) {
} }
function draggableHandleDragEnter(e) { function draggableHandleDragEnter(e) {
e.target.classList.add('over') let element = e.target
if (!element.classList) {
element = element.parentElement
}
element.classList.add('over')
} }
function draggableHandleDragLeave(e) { function draggableHandleDragLeave(e) {
// this/e.target is previous target element. // this/e.target is previous target element.
e.target.classList.remove('over') let element = e.target
if (!element.classList) {
element = element.parentElement
}
element.classList.remove('over')
} }
function draggableHandleDrop(e) { function draggableHandleDrop(e) {
// this/e.target is current target element. // this/e.target is current target element.
e.preventDefault()
let tgt = e.target let tgt = e.target
let src = document.querySelector("[data-move-id=\"" + e.dataTransfer.getData("text/plain") + "\"]") let src = document.querySelector("[data-move-id=\"" + e.dataTransfer.getData("text/plain") + "\"]")
@ -59,12 +68,12 @@ function draggableHandleDragEnd(e) {
function sortableInit(event) { function sortableInit(event) {
for (let e of document.querySelectorAll("[draggable]")) { for (let e of document.querySelectorAll("[draggable]")) {
e.addEventListener('dragstart', draggableHandleDragStart, false) e.addEventListener('dragstart', draggableHandleDragStart)
e.addEventListener('dragenter', draggableHandleDragEnter, false) e.addEventListener('dragenter', draggableHandleDragEnter)
e.addEventListener('dragover', draggableHandleDragOver, false) e.addEventListener('dragover', draggableHandleDragOver)
e.addEventListener('dragleave', draggableHandleDragLeave, false) e.addEventListener('dragleave', draggableHandleDragLeave)
e.addEventListener('drop', draggableHandleDrop, false) e.addEventListener('drop', draggableHandleDrop)
e.addEventListener('dragend', draggableHandleDragEnd, false) e.addEventListener('dragend', draggableHandleDragEnd)
} }
} }